Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use Ignition GUI render event #598

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

chapulina
Copy link
Contributor

The render event was ported from ign-gazebo to ign-gui on gazebosim/gz-gui#68 but ign-gazebo isn't making use of the GUI event yet.

The plan is to:

This PR accomplishes the 1st bullet point.

This way, users can write ign-gui plugins that work both with ignition::gui::Scene3D and ignition::gazebo::Scene3D.

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering labels Jan 29, 2021
@chapulina chapulina requested a review from jennuine January 29, 2021 22:26
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #598 (4b1b1c0) into ign-gazebo3 (01fc2ff) will increase coverage by 12.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #598       +/-   ##
================================================
+ Coverage        65.71%   77.71%   +12.00%     
================================================
  Files              127      208       +81     
  Lines             6238    11595     +5357     
================================================
+ Hits              4099     9011     +4912     
- Misses            2139     2584      +445     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (+100.00%) ⬆️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e98e1...21c5817. Read the comment docs.

@chapulina chapulina requested a review from nkoenig February 1, 2021 19:55
@chapulina chapulina mentioned this pull request Feb 2, 2021
@chapulina chapulina merged commit 4eda53f into ign-gazebo3 Feb 2, 2021
@chapulina chapulina deleted the chapulina/3/renderevent branch February 2, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants