Remove playback <path> SDF param in Dome #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
…cs/ign-gazebo into remove_playback_path_dome
JShep1
reviewed
Jan 22, 2021
Signed-off-by: Mabel Zhang <[email protected]>
…cs/ign-gazebo into remove_playback_path_dome
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #570 +/- ##
===============================================
+ Coverage 77.29% 77.35% +0.05%
===============================================
Files 208 213 +5
Lines 11198 11925 +727
===============================================
+ Hits 8655 9224 +569
- Misses 2543 2701 +158
Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
|
Not sure why tests are failing, possibly flaky tests, re-running CI |
|
All green except ServerRepeat/SceneBroadcasterTest.State/0, which is flaky: https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/5269/testReport/(root)/ServerRepeat_SceneBroadcasterTest/State_0/history/ Merging... if I can figure out which merge button to push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #293 for Dome
<path>SDF parameter forLogPlayback<path>to<playback_path>to disambiguate between the two, similar to what's already done for<record_path>