Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common::setenv for portability to Windows #561

Merged
merged 10 commits into from
Jan 20, 2021
Merged

Use common::setenv for portability to Windows #561

merged 10 commits into from
Jan 20, 2021

Conversation

j-rivero
Copy link
Contributor

Use the ignition::common setenv to be able to work on Windows. Also added missing std:: namespaces to getenv.

@j-rivero j-rivero requested a review from chapulina as a code owner January 15, 2021 16:20
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 15, 2021
chapulina
chapulina reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is fixed.

src/network/PeerTracker_TEST.cc Outdated Show resolved Hide resolved
test/integration/save_world.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #561 (12ca7f6) into main (9246d67) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   77.57%   77.63%   +0.05%     
==========================================
  Files         211      211              
  Lines       11582    11583       +1     
==========================================
+ Hits         8985     8992       +7     
+ Misses       2597     2591       -6
Impacted Files Coverage Δ
src/Util.cc 95.18% <100.00%> (+0.02%) ⬆️
src/SimulationRunner.cc 94.76% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9246d67...12ca7f6. Read the comment docs.

@chapulina chapulina merged commit 60aac16 into main Jan 20, 2021
@chapulina chapulina deleted the jrivero/win/env_common branch January 20, 2021 04:24
@j-rivero j-rivero mentioned this pull request Jan 20, 2021
Open
18 tasks
chapulina pushed a commit that referenced this pull request Mar 3, 2021
@j-rivero @chapulina
Backport #561: Use common::setenv
d3758c2 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Mar 3, 2021
Merged
7 tasks
chapulina added a commit that referenced this pull request Mar 8, 2021
@chapulina @j-rivero
Backport #561: Use common::setenv (#666)
7d98df4 
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Jose Luis Rivero <[email protected]>
@traversaro traversaro mentioned this pull request Mar 28, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina