Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in migration plugins tutorial #543

Merged

Conversation

nlamprian
Copy link
Contributor

No description provided.

@nlamprian nlamprian requested a review from maryaB-osr as a code owner January 9, 2021 12:19
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 9, 2021
@chapulina chapulina self-requested a review January 11, 2021 20:00
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes! I should have actually tried to compile the examples before putting them on the tutorial.

@chapulina chapulina added the documentation Improvements or additions to documentation label Jan 12, 2021
@chapulina
Copy link
Contributor

Just need DCO signed to merge. Thanks!

@nlamprian nlamprian force-pushed the nlamprian/fix_migration_plugins branch from ec97ef8 to d00bf53 Compare January 12, 2021 01:09
@chapulina chapulina merged commit 6544c78 into gazebosim:ign-gazebo3 Jan 12, 2021
nkoenig added a commit that referenced this pull request Jan 13, 2021
* Automatically load a subset of world plugins (#281)

Feature to allow loading of a default set of system plugins from a file. This behavior will trigger when a world sdf file is loaded with no plugins defined.  In this case, the simulator will load the plugins from a series of locations including environment variable, the users home folder, and finally in the installation directory.

This should allow users to not have to specify the same set of plugins in every world sdf file.

Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>

* Added missing version namespace (#541)

* Added missing version namespace

Signed-off-by: Nate Koenig <[email protected]>

* Fix codecheck

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>

* Fix examples in migration plugins tutorial (#543)

Signed-off-by: Nick Lamprianidis <[email protected]>

* Prepare for 3.7.0 release (#552)

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Nick Lamprianidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants