Added missing version namespace #541
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #541 +/- ##
============================================
Coverage 77.61% 77.61%
============================================
Files 208 208
Lines 11526 11526
============================================
Hits 8946 8946
Misses 2580 2580
Continue to review full report at Codecov.
|
|
That one was an interesting change. inline namespaces are specially designed to modify the binary symbols names so changing it in a released branch should ring the alarms. However, the abichecker is happy with it. In fact looking for some code modified here does not appear anywhere in binaries: My hypothesis is that the file belongs to a private part (details) and that makes the real work of being private and not exposed to public ABI. I might be wrong and the abichecker could also be wrong and weird problems might appear somehow in the new release. Keep an eye on these change if that happen. |
* Automatically load a subset of world plugins (#281) Feature to allow loading of a default set of system plugins from a file. This behavior will trigger when a world sdf file is loaded with no plugins defined. In this case, the simulator will load the plugins from a series of locations including environment variable, the users home folder, and finally in the installation directory. This should allow users to not have to specify the same set of plugins in every world sdf file. Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Added missing version namespace (#541) * Added missing version namespace Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Fix examples in migration plugins tutorial (#543) Signed-off-by: Nick Lamprianidis <[email protected]> * Prepare for 3.7.0 release (#552) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nick Lamprianidis <[email protected]>
Adding this to help fix downstream users of ign-gazebo, such as ign-launch.
Signed-off-by: Nate Koenig [email protected]