Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pose msg conversion when msg is missing orientation #450

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 5, 2020

The change makes sure the orientation is correct when a pose message is converted.
Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested a review from chapulina as a code owner November 5, 2020 19:28
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #450 into ign-gazebo3 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #450   +/-   ##
============================================
  Coverage        77.27%   77.27%           
============================================
  Files              205      205           
  Lines            11011    11012    +1     
============================================
+ Hits              8509     8510    +1     
  Misses            2502     2502           
Impacted Files Coverage Δ
src/Conversions.cc 81.57% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074098d...848005b. Read the comment docs.

@chapulina chapulina merged commit 432028f into ign-gazebo3 Nov 6, 2020
@chapulina chapulina deleted the nkoenig/fix_pose_msg_conversion branch November 6, 2020 03:14
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants