Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #411

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Improve fork experience #411

merged 2 commits into from
Oct 20, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #411 into ign-gazebo3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #411   +/-   ##
============================================
  Coverage        77.30%   77.30%           
============================================
  Files              205      205           
  Lines            11018    11018           
============================================
  Hits              8518     8518           
  Misses            2500     2500           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff33091...0e45c43. Read the comment docs.

@chapulina chapulina self-assigned this Oct 19, 2020
@chapulina chapulina requested a review from ahcorde October 19, 2020 18:41
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde
Copy link
Contributor

ahcorde commented Oct 20, 2020

@osrf-jenkins run tests please

@ahcorde
Copy link
Contributor

ahcorde commented Oct 20, 2020

@osrf-jenkins run tests please

1 similar comment
@ahcorde
Copy link
Contributor

ahcorde commented Oct 20, 2020

@osrf-jenkins run tests please

@chapulina chapulina merged commit aa6c62b into ign-gazebo3 Oct 20, 2020
@chapulina chapulina deleted the chapulina/3/forkX branch October 20, 2020 22:30
mjcarroll pushed a commit that referenced this pull request Oct 21, 2020
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants