Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots to GUI config tutorial #406

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

chapulina
Copy link
Contributor

While working on #405, I got motivated to also add some screenshots to the GUI config tutorial added in #278.

@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 14, 2020
@chapulina chapulina requested a review from maryaB-osr as a code owner October 14, 2020 01:51
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #406 into ign-gazebo3 will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #406      +/-   ##
===============================================
- Coverage        77.19%   77.13%   -0.06%     
===============================================
  Files              203      203              
  Lines            10864    10864              
===============================================
- Hits              8386     8380       -6     
- Misses            2478     2484       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 93.59% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca9862...38fb87f. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit 050d10b into ign-gazebo3 Oct 14, 2020
@chapulina chapulina deleted the chapulina/3/gui_config_imgs branch October 14, 2020 16:44
mjcarroll pushed a commit that referenced this pull request Oct 21, 2020
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants