Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more model APIs #349

Merged
merged 8 commits into from
Sep 17, 2020
Merged

Add more model APIs #349

merged 8 commits into from
Sep 17, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Sep 11, 2020

Partially addresses #325

Added a new tutorial / guide which lists all of gazebo::physics::Model functions and how they map to existing Ignition Gazebo functionality.

Also added several functions to Model.hh and Util.hh.

Finally, I made more of the model's components be displayed on the component inspector, related to #158.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the migration Helps with migration from Gazebo classic to Ignition label Sep 11, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #349 into ign-gazebo3 will increase coverage by 0.00%.
The diff coverage is 81.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #349   +/-   ##
============================================
  Coverage        77.32%   77.32%           
============================================
  Files              197      197           
  Lines            10530    10577   +47     
============================================
+ Hits              8142     8179   +37     
- Misses            2388     2398   +10     
Impacted Files Coverage Δ
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
...e/ignition/gazebo/components/AngularVelocityCmd.hh 100.00% <ø> (ø)
...de/ignition/gazebo/components/LinearVelocityCmd.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 9.09% <0.00%> (-0.24%) ⬇️
src/systems/physics/Physics.cc 70.19% <0.00%> (-0.93%) ⬇️
src/Model.cc 95.89% <93.18%> (-4.11%) ⬇️
src/Util.cc 94.80% <100.00%> (+1.58%) ⬆️
src/ign.cc 72.22% <0.00%> (-0.76%) ⬇️
src/systems/log/LogRecord.cc 81.90% <0.00%> (-0.46%) ⬇️
src/systems/log/LogPlayback.cc 60.95% <0.00%> (-0.19%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9337ae...f758c15. Read the comment docs.

@chapulina chapulina requested a review from JShep1 September 14, 2020 18:54
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a couple small nits and a question, but pending that and CI, this should be good to go.

include/ignition/gazebo/Model.hh Outdated Show resolved Hide resolved
include/ignition/gazebo/Util.hh Show resolved Hide resolved
include/ignition/gazebo/components/LinearVelocityCmd.hh Outdated Show resolved Hide resolved
src/systems/physics/Physics.cc Show resolved Hide resolved
tutorials/migration_model_api.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from JShep1 September 15, 2020 23:54
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI this is good to go!

@chapulina chapulina merged commit f6b4b0a into ign-gazebo3 Sep 17, 2020
@chapulina chapulina deleted the chapulina/3/model_api branch September 17, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel migration Helps with migration from Gazebo classic to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants