-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more model APIs #349
Add more model APIs #349
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #349 +/- ##
============================================
Coverage 77.32% 77.32%
============================================
Files 197 197
Lines 10530 10577 +47
============================================
+ Hits 8142 8179 +37
- Misses 2388 2398 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a couple small nits and a question, but pending that and CI, this should be good to go.
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending CI this is good to go!
Partially addresses #325
Added a new tutorial / guide which lists all of
gazebo::physics::Model
functions and how they map to existing Ignition Gazebo functionality.Also added several functions to
Model.hh
andUtil.hh
.Finally, I made more of the model's components be displayed on the component inspector, related to #158.