Make sure OpenGL core profile context is used by GzScene3D #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iche033
reviewed
Sep 9, 2020
Should fix gazebosim/gz-rendering#128 . Signed-off-by: Martin Pecka <[email protected]>
Signed-off-by: Martin Pecka <[email protected]>
|
looks good to me. Just need to trigger another round of CI builds once jenkins is back online.. |
|
I'm not sure what the test results mean... None of the failures should be related. |
|
the test failures should be unrelated and are captured in gazebosim/gz-rendering#129. |
|
Aahh... I've just triggered a rebuild :-D If that's possible, you can stop it to save buildfarm time. |
iche033
approved these changes
Sep 10, 2020
chapulina
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix gazebosim/gz-rendering#128 .