-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support relative paths for PBR materials #328
Conversation
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, I tried with this model: https://app.ignitionrobotics.org/chapulina/fuel/models/Rescue%20Randy%20-%20relative%20paths
This is blocked by a libSDFormat8 release. |
@osrf-jenkins run tests, you can do it! |
@osrf-jenkins run tests, SDFormat 8.9.0 is out! |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo2 #328 +/- ##
===============================================
+ Coverage 78.11% 78.13% +0.01%
===============================================
Files 183 183
Lines 10029 10038 +9
===============================================
+ Hits 7834 7843 +9
Misses 2195 2195
Continue to review full report at Codecov.
|
Resolves #286.
Requires: gazebosim/sdformat#349.
To test, you can modify PBR map URIs similar to the following.
Old
New
Signed-off-by: Nate Koenig [email protected]