-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests & Warnings: Qt 5.14, breadcrumbs, Gui, ign_TEST #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
PERFORMANCE_each failed @osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo2 #327 +/- ##
============================================
Coverage 78.10% 78.10%
============================================
Files 183 183
Lines 9979 9979
============================================
Hits 7794 7794
Misses 2185 2185 Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
chapulina
changed the title
Make breadcrumbs test more robust
Tests & Warnings: Qt 5.14, breadcrumbs, Gui, ign_TEST
Sep 2, 2020
Signed-off-by: Louise Poubel <[email protected]>
Merged
azeey
approved these changes
Sep 2, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumbs remaining test was added on #308 and has been flaking / failing on CI.
Resolved the homebrew warnings due to Qt 5.14, see gazebosim/gz-gui#113.
Also disabled
Gui_TEST
on macOS as it is already done onign-gazebo3
.