Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests & Warnings: Qt 5.14, breadcrumbs, Gui, ign_TEST #327

Merged
merged 6 commits into from
Sep 4, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Sep 2, 2020

The breadcrumbs remaining test was added on #308 and has been flaking / failing on CI.

Resolved the homebrew warnings due to Qt 5.14, see gazebosim/gz-gui#113.

Also disabled Gui_TEST on macOS as it is already done on ign-gazebo3.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Sep 2, 2020
@chapulina chapulina requested a review from nkoenig September 2, 2020 03:06
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Sep 2, 2020
@ahcorde
Copy link
Contributor

ahcorde commented Sep 2, 2020

PERFORMANCE_each failed

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #327 into ign-gazebo2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo2     #327   +/-   ##
============================================
  Coverage        78.10%   78.10%           
============================================
  Files              183      183           
  Lines             9979     9979           
============================================
  Hits              7794     7794           
  Misses            2185     2185           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6204194...127f79d. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the title Make breadcrumbs test more robust Tests & Warnings: Qt 5.14, breadcrumbs, Gui, ign_TEST Sep 2, 2020
@chapulina chapulina added the macOS macOS support label Sep 2, 2020
@chapulina chapulina mentioned this pull request Sep 2, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 8bc99bf into ign-gazebo2 Sep 4, 2020
@chapulina chapulina deleted the chapulina/breadcrumbs_tests branch September 4, 2020 22:13
@chapulina chapulina mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants