Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish remaining breadcrumb deployments. #308

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 24, 2020

This adds a <topic>/remaining topic that publishes the remaining deployments.

Signed-off-by: Nate Koenig [email protected]

Nate Koenig added 2 commits August 24, 2020 15:45
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from chapulina as a code owner August 24, 2020 22:47
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #308 into ign-gazebo2 will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo2     #308      +/-   ##
===============================================
+ Coverage        78.03%   78.10%   +0.06%     
===============================================
  Files              183      183              
  Lines             9975     9979       +4     
===============================================
+ Hits              7784     7794      +10     
+ Misses            2191     2185       -6     
Impacted Files Coverage Δ
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.cc 88.69% <100.00%> (+0.27%) ⬆️
src/SimulationRunner.cc 96.39% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865e77d...c64b8fd. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only suggestion would be to add a test.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig
Copy link
Contributor Author

nkoenig commented Aug 27, 2020

Added test: c64b8fd

@nkoenig nkoenig merged commit f05fb0b into ign-gazebo2 Aug 27, 2020
@nkoenig nkoenig deleted the breadcrumb_remianing branch August 27, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants