Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add marker array service #302

Merged
merged 7 commits into from
Aug 27, 2020
Merged

Add marker array service #302

merged 7 commits into from
Aug 27, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Aug 20, 2020 •
edited
Loading

Closes #287

Signed-off-by: John Shepherd [email protected]

Add marker array service
9100067 
Signed-off-by: John Shepherd <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 20, 2020
Cleanup print statement
9156878 
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 linked an issue Aug 20, 2020 that may be closed by this pull request
Add service for rendering multiple markers #287
Closed
@JShep1 JShep1 removed a link to an issue Aug 20, 2020
Add service for rendering multiple markers #287
Closed
@JShep1 JShep1 linked an issue Aug 20, 2020 that may be closed by this pull request
Add service for rendering multiple markers #287
Closed
@chapulina chapulina added the rendering Involves Ignition Rendering label Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #302 into ign-gazebo3 will increase coverage by 16.36%.
The diff coverage is 75.39%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #302       +/-   ##
================================================
+ Coverage        65.71%   82.07%   +16.36%     
================================================
  Files              127      186       +59     
  Lines             6238     9677     +3439     
================================================
+ Hits              4099     7942     +3843     
+ Misses            2139     1735      -404
Impacted Files Coverage Δ
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/detachable_joint/DetachableJoint.hh 100.00% <ø> (ø)
src/systems/diff_drive/DiffDrive.hh 100.00% <ø> (ø)
src/systems/joint_controller/JointController.hh 100.00% <ø> (ø)
...stems/joint_state_publisher/JointStatePublisher.hh 100.00% <ø> (ø)
src/systems/user_commands/UserCommands.hh 100.00% <ø> (ø)
src/systems/user_commands/UserCommands.cc 77.86% <16.66%> (+66.24%) ⬆️
src/systems/battery_plugin/LinearBatteryPlugin.cc 42.08% <20.83%> (ø)
src/systems/physics/Physics.cc 71.12% <50.00%> (+35.87%) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b11a02...be4a950. Read the comment docs.

John Shepherd and others added 2 commits August 27, 2020 10:23
Update service request
348ce27 
Signed-off-by: John Shepherd <[email protected]>
@iche033
remove white space
be4a950 
Signed-off-by: Ian Chen <[email protected]>
@chapulina chapulina merged commit 2d752ce into ign-gazebo3 Aug 27, 2020
@chapulina chapulina deleted the jshep1/add_marker_array_service branch August 27, 2020 23:57
@chapulina chapulina mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 iche033 approved these changes

Assignees

@JShep1 JShep1

Labels
🏰 citadel Ignition Citadel rendering Involves Ignition Rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add service for rendering multiple markers
3 participants
@JShep1 @iche033 @chapulina