-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lib
+.so
from plugin's name
#279
Remove lib
+.so
from plugin's name
#279
Conversation
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like you consistently remove the .so
extension from the plugin filenames. Is there a reason for this?
No, it was just a mistake.
Should I remove those too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR big and need to be broken down into smaller ones?
I think that's fine because it's so repetitive
Should I remove those too?
No, those can stay
I think I shouldn't remove it from the custom plugins like Should I remove it from the |
Signed-off-by: mohamedsayed18 <[email protected]>
It can be removed from all of then,
That would be great, thanks! |
I will work on it. |
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
I didn't remove the extension name from the |
Fix #277.
Is this PR big and need to be broken down into smaller ones?