Sync components removal #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
azeey
requested changes
Aug 5, 2020
Signed-off-by: Martiño Crespo <[email protected]>
azeey
requested changes
Aug 11, 2020
Signed-off-by: Martiño Crespo <[email protected]>
azeey
approved these changes
Aug 11, 2020
Signed-off-by: Martiño Crespo <[email protected]>
|
This looks ready to me. @chapulina, mind taking a quick look? |
chapulina
approved these changes
Aug 12, 2020
Signed-off-by: Martiño Crespo <[email protected]>
chapulina
suggested changes
Aug 14, 2020
Signed-off-by: Martiño Crespo <[email protected]>
|
Is there anything that needs to be done yet? |
|
@osrf-jenkins run tests please |
chapulina
approved these changes
Aug 28, 2020
mihirk284
pushed a commit
to mihirk284/ign-gazebo
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Martiño Crespo <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Martiño Crespo <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sets the
SerializedStateMapandSerializedStatemessages when a component is removed afterEntityComponentManager::RemoveComponentis called. This allows a more precise synchronization between the server and GUIEntityComponentManager.This PR is made in order to solve an issue in #234 already described here (no. 3).
A couple of comments about the PR:
SerializedStateMapmessage after callingRemoveComponent, and another one that checks that a component is actually removed when itsremoveflag in the message is set to true. I've implemented the first one and the second should be already done here.