Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor topics available through components and GUI #266

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

chapulina
Copy link
Contributor

Addresses #85
Requires gazebosim/gz-sensors#33 and gazebosim/gz-transport#153


While working on #239, I thought it would be good to also address #85. This adds a SensorTopic component that can be checked from any system and is also displayed on the GUI. It uses the new API on ign-sensors to get the real topic that is being published, after all inputs and modifications have been applied to it.

⚠️ This PR doesn't add topic components for rendering sensors because the API on this branch doesn't make it easy to access the ECM and the sensor pointer at the same time. The Sensors::CreateSensor function on Dome takes an Entity ID which will make it easier to add topics for those sensors, so my current suggestion is to only support topic components for rendering sensors from Dome. Let me know what you think, @iche033 .

@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jul 30, 2020
@chapulina chapulina linked an issue Jul 30, 2020 that may be closed by this pull request
@chapulina chapulina requested a review from iche033 July 30, 2020 20:47
@chapulina chapulina self-assigned this Aug 3, 2020
@iche033
Copy link
Contributor

iche033 commented Aug 5, 2020

The Sensors::CreateSensor function on Dome takes an Entity ID which will make it easier to add topics for those sensors, so my current suggestion is to only support topic components for rendering sensors from Dome.

sounds good to me.

test/integration/air_pressure_system.cc Outdated Show resolved Hide resolved
test/integration/logical_camera_system.cc Outdated Show resolved Hide resolved
@chapulina chapulina merged commit e1b9812 into ign-gazebo2 Aug 6, 2020
@chapulina chapulina deleted the chapulina/2/topic branch August 6, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify determination of a sensor's topic name
2 participants