Insert Fuel Models

[JShep1]

Ready for Review.

A few things to consider

• Should we add a timeout for the thread loading the fuel model info?
• Should we cache the results from an owner-model query? This would reduce duplicate work Done
• Codecheck is complaing about two unused struct variables stating that they are unused (isFuel and isDownloaded), but I make use of them so I'm not sure if there's another way to go about this or if we add something to make codecheck ignore those lines.

Demo:

[chapulina]

Did a preliminary review, I'll wait for #173 to be merged before reviewing again.

Should we add a timeout for the thread loading the fuel model info?

I'd say this is something that can be handled in a consistent way on ign-fuel-tools. I think we could set CURLOPT_TIMEOUT, which is defaulting to 0 (no timeout).

In any case, if there's something wrong with the server, it should return some error code pretty quickly. So I think this is not extremely important.

Codecheck is complaing about two unused struct variables

Yeah I think with our current cppcheck version all we can do is ignore those lines

[codecov]

Codecov Report

Merging #263 into ign-gazebo2 will increase coverage by 24.38%.
The diff coverage is 76.71%.

@@               Coverage Diff                @@
##           ign-gazebo2     #263       +/-   ##
================================================
+ Coverage        53.78%   78.16%   +24.38%     
================================================
  Files              121      183       +62     
  Lines             5838     9917     +4079     
================================================
+ Hits              3140     7752     +4612     
+ Misses            2698     2165      -533     

Impacted Files	Coverage Δ
include/ignition/gazebo/Server.hh	100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh	61.29% <0.00%> (+61.29%)	⬆️
.../plugins/component_inspector/ComponentInspector.cc	9.41% <0.00%> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh	100.00% <ø> (ø)
src/systems/diff_drive/DiffDrive.hh	100.00% <ø> (ø)
src/systems/joint_controller/JointController.hh	100.00% <ø> (ø)
...stems/joint_state_publisher/JointStatePublisher.hh	100.00% <ø> (ø)
src/systems/physics/Physics.cc	74.12% <ø> (+58.14%)	⬆️
src/systems/user_commands/UserCommands.hh	100.00% <ø> (ø)
src/systems/user_commands/UserCommands.cc	80.32% <16.66%> (ø)
... and 122 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881aae7...c826d38. Read the comment docs.

[chapulina]

Works well! I just have the 2 trivial comments below, otherwise 🚢 it!