-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
igniton gazebo fullscreen #254
igniton gazebo fullscreen #254
Conversation
Signed-off-by: mohamedsayed18 <[email protected]>
<plugin filename="GzScene3D" name="3D View">
<ignition-gui>
<title>3D View</title>
<property type="bool" key="showTitleBar">false</property>
<property type="string" key="state">docked</property>
</ignition-gui>
<engine>ogre2</engine>
<scene>scene</scene>
<ambient_light>0.4 0.4 0.4</ambient_light>
<background_color>0.8 0.8 0.8</background_color>
<fullscreen>true</fullscreen>
</plugin> |
@mohamedsayed18 is working on adding support for toggling fullscreen with the F11 key |
Signed-off-by: mohamedsayed18 <[email protected]>
… into fix_fullscreen
0a35511
to
9d0b96e
Compare
the F11 now toggle between the fullscreen and normal window, I tried to make it maximized window but it didn't work I think maybe it is not supported for qwindow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look too deeply, but when I started ign gazebo
and pressed F11
, nothing happened. I'm not sure why yet, would need to debug. Does that work for you?
Signed-off-by: mohamedsayed18 <[email protected]>
… into fix_fullscreen
It is working and compiling right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working for me! I just have one suggestion below, and also, mind documenting <fullscreen>
on the header?
Signed-off-by: mohamedsayed18 <[email protected]>
… into fix_fullscreen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Introduced a new parameter in the scene3D plugin to launch in fullscreen
fix #224