-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citadel] [TPE] Add velocity cmd #169
Conversation
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
This reverts commit e8bafc3.
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
bde26c6
to
4863437
Compare
Signed-off-by: claireyywang <[email protected]>
4863437
to
a67f260
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #169 +/- ##
===============================================
- Coverage 65.33% 64.93% -0.40%
===============================================
Files 127 129 +2
Lines 6311 6349 +38
===============================================
Hits 4123 4123
- Misses 2188 2226 +38
Continue to review full report at Codecov.
|
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ignore]
This reverts commit d7b9360.
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the integration test. I expanded it a little to check that the robot is moving in the right direciton: 1b88b37
Just left another minor comment. Otherwise changes look good to me.
Signed-off-by: claireyywang <[email protected]>
@osrf-jenkins run tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@osrf-jenkins run tests please |
It looks like this change introduced test failures to ignition_gazebo-ci-ign-gazebo3-homebrew-amd64:
|
It looks like the PeerTracker failure is a known flake (#8), but I'm not sure about the INTEGRATION_physics_system test. |
Im trying to reproduce the physics_system test fail on my local. I'll update here when I get a result. |
weird, I wasn't to get the same test fail on my local build. I reran the homebrew test to see if the failure pops up again |
@jacobperron |
This PR is consisted of a few parts
AngularVelocityCmd
andLinearVelocityCmd
componentsWorldVelocityCmdFeatureList
forSetFreeGroupWorldVelocity
featureangular
andlinear
velocities of Free Group entity inPhysics.cc
velocity_demo.sdf
, which is basicallydiff_drive.sdf
but with different names. I created a separate sdf file to avoid confusion, but open to just usediff_drive.sdf
.velocity_demo
that generatesangular/linearVelocityCmd
on model.Use the following cmds for testing
then hit play button on ignition gazebo window.
Demo gif see below