Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support joint force commands with the Battery plugin #165

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 1, 2020

Joint force commands were not checked in the battery plugin.

To test:

  1. ign gazebo -v 4 examples/worlds/lift_drag_battery.sdf
  2. Listen to the battery topic: ign topic -et /model/lift_drag_demo_model/battery/linear_battery/state
  3. Run simulation.
  4. The battery should be full and not discharging.
  5. Start the propeller: ign topic -t "/model/lift_drag_demo_model/joint/rod_1_joint/cmd_force" -m ignition.msgs.Double -p "data: 0.7"
  6. The battery should start discharging.

Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested a review from caguero June 1, 2020 17:24
@nkoenig nkoenig requested a review from chapulina as a code owner June 1, 2020 17:24
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jun 1, 2020
Signed-off-by: Nate Koenig <[email protected]>
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #165 into ign-gazebo2 will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo2     #165      +/-   ##
===============================================
+ Coverage        62.25%   62.35%   +0.09%     
===============================================
  Files              123      123              
  Lines             6101     6101              
===============================================
+ Hits              3798     3804       +6     
+ Misses            2303     2297       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 88.77% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef44bce...495c1a4. Read the comment docs.

Nate Koenig and others added 2 commits June 2, 2020 05:51
@caguero
Copy link
Contributor

caguero commented Jun 2, 2020

Just one comment, other than that ready to approve.

@nkoenig nkoenig merged commit b2fc97f into ign-gazebo2 Jun 2, 2020
@nkoenig nkoenig deleted the joint_force_battery branch June 2, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants