Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renaming breadcrumb models if there is a name conflict #155

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 26, 2020

Adds a new parameter <allow_renaming> that, when set to true, will rename the spawned breadcrumb model by adding a numeric suffix if there is already a model with the same name in the world. This allows using multiple instances of the same Breadcrumb system and configuration.

@azeey azeey added enhancement New feature or request 📜 blueprint Ignition Blueprint labels May 26, 2020
@azeey azeey requested a review from nkoenig May 26, 2020 19:36
@azeey azeey requested a review from chapulina as a code owner May 26, 2020 19:36
@azeey azeey self-assigned this May 26, 2020
Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a preference for defaulting allow_renaming to false but I'd be ok if it's decided it's important to change it.

src/systems/breadcrumbs/Breadcrumbs.hh Show resolved Hide resolved
@azeey azeey merged commit 6f31224 into gazebosim:ign-gazebo2 Jun 1, 2020
@azeey azeey deleted the breadcrumb_allow_rename branch June 1, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants