Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 to 3 may2020 #149

Merged
merged 10 commits into from
May 21, 2020
Merged

2 to 3 may2020 #149

merged 10 commits into from
May 21, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 21, 2020

Merge ign-gazebo2 to ign-gazebo3.

John and others added 6 commits May 14, 2020 10:19
Signed-off-by: John Shepherd <[email protected]>
* Support multi entity spawn

Signed-off-by: Nate Koenig <[email protected]>

* Added more documentation

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested review from chapulina and iche033 as code owners May 21, 2020 00:44
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #149 into ign-gazebo3 will decrease coverage by 0.09%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #149      +/-   ##
===============================================
- Coverage        65.71%   65.61%   -0.10%     
===============================================
  Files              127      127              
  Lines             6238     6250      +12     
===============================================
+ Hits              4099     4101       +2     
- Misses            2139     2149      +10     
Impacted Files Coverage Δ
src/systems/user_commands/UserCommands.hh 100.00% <ø> (ø)
src/systems/user_commands/UserCommands.cc 11.85% <16.66%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f239b...1c19959. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@nkoenig
Copy link
Contributor Author

nkoenig commented May 21, 2020

LGTM with happy CI

I'll need to make an ign-msgs 5.3 release, correct? And, bump the required version here.

@chapulina
Copy link
Contributor

I'll need to make an ign-msgs 5.3 release, correct? And, bump the required version here.

Yup, and also bump it in the release repo, i.e.: https://github.com/ignition-release/ign-gazebo3-release/blob/master/ubuntu/debian/control#L20

Nate Koenig added 4 commits May 20, 2020 18:16
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig merged commit 37a6cbe into ign-gazebo3 May 21, 2020
@nkoenig nkoenig deleted the 2_to_3_may2020 branch May 21, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants