Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed light gui component inspector #1337

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Fixed light gui component inspector #1337

merged 3 commits into from
Feb 15, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 14, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Intensity wasn't changing and the type index value was wrong.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from iche033 as a code owner February 14, 2022 19:02
@ahcorde ahcorde self-assigned this Feb 14, 2022
@ahcorde ahcorde requested a review from chapulina as a code owner February 14, 2022 19:02
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 14, 2022
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1337 (51dd43e) into ign-gazebo5 (bcb1a36) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo5    #1337   +/-   ##
============================================
  Coverage        66.91%   66.91%           
============================================
  Files              276      276           
  Lines            20926    20930    +4     
============================================
+ Hits             14002    14005    +3     
- Misses            6924     6925    +1     
Impacted Files Coverage Δ
src/rendering/RenderUtil.cc 44.82% <75.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb1a36...51dd43e. Read the comment docs.

@ahcorde ahcorde merged commit 211289f into ign-gazebo5 Feb 15, 2022
@ahcorde ahcorde deleted the ahcorde/fix/lights branch February 15, 2022 08:25
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants