Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNIT_SdfGenerator_TEST #1319

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Fix UNIT_SdfGenerator_TEST #1319

merged 2 commits into from
Feb 7, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 2, 2022

🦟 Bug fix

Summary

UNIT_SdfGenerator_TEST is failing in Edifice in all builds. This should fix the test.

This fixed in Fortress in #1286

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from chapulina as a code owner February 2, 2022 05:03
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1319 (64d3344) into ign-gazebo5 (1173c06) will decrease coverage by 0.06%.
The diff coverage is 59.01%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5    #1319      +/-   ##
===============================================
- Coverage        66.27%   66.21%   -0.07%     
===============================================
  Files              255      255              
  Lines            20213    20281      +68     
===============================================
+ Hits             13397    13429      +32     
- Misses            6816     6852      +36     
Impacted Files Coverage Δ
...clude/ignition/gazebo/components/CenterOfVolume.hh 100.00% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.hh 50.00% <ø> (ø)
...int_position_controller/JointPositionController.cc 67.54% <0.00%> (-2.46%) ⬇️
src/gui/plugins/scene3d/Scene3D.cc 10.12% <28.12%> (+0.42%) ⬆️
src/systems/air_pressure/AirPressure.cc 72.15% <71.42%> (-1.83%) ⬇️
src/systems/altimeter/Altimeter.cc 72.83% <71.42%> (-1.83%) ⬇️
src/systems/logical_camera/LogicalCamera.cc 74.41% <71.42%> (-1.84%) ⬇️
src/systems/magnetometer/Magnetometer.cc 70.11% <71.42%> (-1.49%) ⬇️
src/systems/imu/Imu.cc 71.73% <73.33%> (-1.52%) ⬇️
src/systems/thruster/Thruster.cc 90.26% <75.00%> (-1.82%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d33ab...64d3344. Read the comment docs.

@iche033 iche033 merged commit 012c25c into ign-gazebo5 Feb 7, 2022
@iche033 iche033 deleted the fix_sdfgenerator_test branch February 7, 2022 22:19
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants