Port support for computing model bounding box in physics system #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
chapulina
reviewed
May 7, 2020
Signed-off-by: Ian Chen <[email protected]>
nkoenig
approved these changes
May 8, 2020
|
Is an ign-physics release needed to fix the builds? |
I'm ready to make a release once this is approved: gazebosim/gz-physics#54 |
chapulina
approved these changes
May 8, 2020
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #127 +/- ##
===============================================
- Coverage 66.12% 65.87% -0.25%
===============================================
Files 122 123 +1
Lines 5915 5955 +40
===============================================
+ Hits 3911 3923 +12
- Misses 2004 2032 +28
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting changes from this bitbucket PR that was merged into ign-gazebo2:
https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-gazebo/pull-requests/546/page/1
see original changes in this commit: 4cdef0c
Signed-off-by: Ian Chen [email protected]