Skip failing Windows tests #1205
Conversation
Blast545
added
tests
|
Worskpace temp error on the Windows pr job:
Manual rebuild:
|
| @@ -92,7 +92,8 @@ class EntityFeatureMapFixture: public InternalFixture<::testing::Test> | |||
| public: EnginePtrType engine; | |||
| }; | |||
|
|
|||
| TEST_F(EntityFeatureMapFixture, AddCastRemoveEntity) | |||
| // See https://github.com/ignitionrobotics/ign-gazebo/issues/1175 | |||
| TEST_F(EntityFeatureMapFixture, IGN_UTILS_TEST_ENABLE_ONLY_LINUX(AddCastRemoveEntity)) | |||
There was a problem hiding this comment.
Can this be disabled only on Windows?
There was a problem hiding this comment.
Sure, my bad there. Addressed here: 5901c2b
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Blast545
force-pushed
the
blast545/skip_windows_tests
branch
from
4905869 to
5901c2b
Compare
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo5 #1205 +/- ##
===============================================
- Coverage 65.99% 65.99% -0.01%
===============================================
Files 255 255
Lines 20137 20137
===============================================
- Hits 13290 13289 -1
- Misses 6847 6848 +1
Continue to review full report at Codecov.
|
Cleaned up the workspace, and retrying.
|
|
@ros-pull-request-builder retest this please |
Whaaat did that work? Are @osrf-jenkins and @ros-pull-request-builder doing exactly the same thing? 😱 |
|
@chapulina I actually tried and wasn't expecting it to work, I was surprised in a good way. |
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
|
There seems to be an error with the PR jobs. For some reason, at least for this PR, after I add commits to retrigger the PR logic it tries to test against |
|
@ros-pull-request-builder retest this please |
|
The PR job is not showing anymore failures for Windows, I would say this is ready for merge: It has 100+ warnings though. I think we can iterate on those after #990 gets merged. |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: Jorge Perez [email protected]
First step towards #1175
Summary
As the title says, skips Windows tests for
ign-gazebo5. Will get green Windows buildfarm before merging.Checklist
Note to maintainers: Remember to use Squash-Merge