Fix SDFormat generation of pose elements #1069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fixes a bug when generating SDFormat strings for included models with poses that use one of the newly added attributes (
//pose[@degrees]
and//pose[@rotation_format]
). The issues comes from assigning an updated pose form the ECM to a<pose>
element without clearing its attributes. For example, here are a couple ofpose
tags from the original world:The generated world will currently have, which are both incorrect.
After this PR, the output will be
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge