Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 4.10.0 release #1029

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Prepare for 4.10.0 release #1029

merged 1 commit into from
Sep 15, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 15, 2021

Signed-off-by: Ian Chen [email protected]

🎈 Release

Preparation for 4.10.0 release.

Comparison to 4.9.1: https://github.com/ignitionrobotics/ign-gazebo/compare/ignition-gazebo4_4.9.1..bump_4.10.0

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 requested a review from chapulina as a code owner September 15, 2021 21:23
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1029 (dbf77ec) into ign-gazebo4 (68dcf5d) will not change coverage.
The diff coverage is n/a.

❗ Current head dbf77ec differs from pull request most recent head 5ccdb94. Consider uploading reports for the commit 5ccdb94 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo4    #1029   +/-   ##
============================================
  Coverage        67.10%   67.10%           
============================================
  Files              243      243           
  Lines            18212    18212           
============================================
  Hits             12222    12222           
  Misses            5990     5990           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dcf5d...5ccdb94. Read the comment docs.

@iche033 iche033 merged commit 6d1b4e6 into ign-gazebo4 Sep 15, 2021
@iche033 iche033 deleted the bump_4.10.0 branch September 15, 2021 22:48
@chapulina
Copy link
Contributor

Looking at the diff, I think there are missing changelog entries:

ignition-gazebo4_4.9.1...ign-gazebo4

Also, we should have bumped the dependency requirements in ign-gazebo4-release, see the changes in CMakeLists:

ignition-gazebo4_4.9.1...ign-gazebo4#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

@iche033
Copy link
Contributor Author

iche033 commented Sep 15, 2021

updates to ign-gazebo4 changelog:
#1031

ign-gazebo4-release dep update:
gazebo-release/ign-gazebo4-release#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants