ci: add golangci depguard rule for the errors package #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
requested review from
ilgooz,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
Pantani
approved these changes
Nov 9, 2023
ilgooz
pushed a commit
that referenced
this pull request
Dec 13, 2023
* create a wrapper for errors * use join to wrap 2 errors * add changelog * rollback some deps * rollback more go deps * rollback go deps * rollback mod requires * add comments and rationale * improve rationale * ci: add golangci depguard rule for the errors package (#3740) Co-authored-by: Danilo Pantani <[email protected]> * remove duplicated import * change pkg from xerrors to errors * rollback go.mod * remove unused pkg * fix goanalysis_test * remove unused package * use errors.Errorf instead fmt.Errorf --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to enforce using
github.com/ignite/cli/ignite/pkg/xerrorsfor errors