Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scaffolding of application or module called "ibc" #3386

Closed
aljo242 opened this issue Jan 6, 2023 · 3 comments · Fixed by #3706
Closed

Prevent scaffolding of application or module called "ibc" #3386

aljo242 opened this issue Jan 6, 2023 · 3 comments · Fixed by #3706
Assignees
Labels
good first issue Good for newcomers type:bug Something isn't working
Milestone

Comments

@aljo242
Copy link
Contributor

aljo242 commented Jan 6, 2023

This is currently allowed but will lead to a KVStore key collision:

panic: Potential key collision between KVStores:ibc - ibc
@aljo242 aljo242 added type:bug Something isn't working good first issue Good for newcomers labels Jan 6, 2023
@amedumer
Copy link

Hey! I want to contribute to the project and I think this can be a great starting point. Can I have this issue?

@0fatih
Copy link
Contributor

0fatih commented Jul 12, 2023

It is already there. These reservedNames are not allowed. When I tried to create a module with the name "ibc", I got this error:

✘ Ibc is a reserved name and can't be used as a module name

I think we can close this.

@Pantani Pantani added this to the v0.29 milestone Oct 17, 2023
@Pantani
Copy link
Collaborator

Pantani commented Oct 18, 2023

@0fatih we should also block to create chains called IBC, because the default module will be IBC:
e.g.:
ignite s chain github.com/ignite/ibc

@Pantani Pantani self-assigned this Oct 18, 2023
@Pantani Pantani moved this from Todo to In Review in Ignite CLI Masterboard Oct 18, 2023
@Pantani Pantani moved this from In Review to Done in Ignite CLI Masterboard Oct 30, 2023
@Pantani Pantani modified the milestones: v0.29, v0.28 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants