Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider having RPCAddress in the accounts section of config.yml #3043

Closed
fadeev opened this issue Nov 2, 2022 · 1 comment · Fixed by #3722
Closed

Reconsider having RPCAddress in the accounts section of config.yml #3043

fadeev opened this issue Nov 2, 2022 · 1 comment · Fixed by #3722
Assignees
@Pantani
Milestone
v28

Comments

@fadeev
Copy link
Contributor

fadeev commented Nov 2, 2022

Why do we even need this? 🤯

cli/ignite/chainconfig/config/config.go

Lines 45 to 46 in c767caf

// The RPCAddress off the chain that account is issued at.
RPCAddress string `yaml:"rpc_address,omitempty"`

@aljo242
Copy link
Contributor

aljo242 commented Nov 3, 2022

@ilgooz @lubtd

@Pantani Pantani moved this to Backlog in Ignite CLI Masterboard Oct 31, 2023
@Pantani Pantani added this to the v0.29 milestone Oct 31, 2023
@Pantani Pantani mentioned this issue Nov 1, 2023
Merged
@Pantani Pantani self-assigned this Nov 1, 2023
@Pantani Pantani moved this from Backlog to In Review in Ignite CLI Masterboard Nov 1, 2023
@Pantani Pantani moved this from In Review to Done in Ignite CLI Masterboard Nov 7, 2023
@Pantani Pantani modified the milestones: v0.29, v0.28 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pantani Pantani

Labels
None yet
Projects
Ignite CLI Masterboard
Status: Done
Milestone
v28
Development

Successfully merging a pull request may close this issue.

chore: remove unused parameters from the config yaml ignite/cli
3 participants
@fadeev @Pantani @aljo242