Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cliui: use pointers for spinner object to prevent printing inconsistencies #2941

Closed
lumtis opened this issue Oct 18, 2022 · 0 comments · Fixed by #2943
Closed

cliui: use pointers for spinner object to prevent printing inconsistencies #2941

lumtis opened this issue Oct 18, 2022 · 0 comments · Fixed by #2943
Assignees
@jeronimoalbi
Labels
type:bug Something isn't working

Comments

@lumtis
Copy link
Contributor

lumtis commented Oct 18, 2022

Referring to this message: #2920 (comment)

Use pointers to solve the underlined issues.

Currently if a session is initializes without cliui.StartSpinner()

session := cliui.New()

there are printing inconsistencies as the spinner will be nil in the high-level method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeronimoalbi jeronimoalbi

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change session to use the same spinner reference ignite/cli
2 participants
@jeronimoalbi @lumtis