Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold int64 instead of int32 when a field type is int #1723

Closed
lumtis opened this issue Oct 26, 2021 · 0 comments · Fixed by #4167
Closed

Scaffold int64 instead of int32 when a field type is int #1723

lumtis opened this issue Oct 26, 2021 · 0 comments · Fixed by #4167
Assignees
@julienrbrt
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:enh Improvement or update to existing feature(s).

Comments

@lumtis
Copy link
Contributor

lumtis commented Oct 26, 2021

Would there be any practical reason to keep scaffolding type int32 for field type with int specified in the CLI?

If no, int64 would allows to scaffold a field that has the value of a UNIX timestamp (and it would also make it more consistent with uint that is already uint64)
@lumtis lumtis added the type:request Feature request. label Oct 26, 2021
@lumtis lumtis added the component:scaffold Feature, enhancement, or refactor related to scaffolding. label Nov 8, 2021
@fadeev fadeev removed the type:request Feature request. label Sep 17, 2022
@salmad3 salmad3 moved this to To Discuss in Ignite CLI Masterboard Mar 12, 2024
@salmad3 salmad3 added type:enh Improvement or update to existing feature(s). and removed needs-triage labels May 22, 2024
@salmad3 salmad3 moved this from To Discuss to Todo in Ignite CLI Masterboard May 22, 2024
@julienrbrt julienrbrt mentioned this issue May 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Ignite CLI Masterboard May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:enh Improvement or update to existing feature(s).
Projects
Ignite CLI Masterboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(templates)!: scaffold int64 instead of int32 ignite/cli
4 participants
@fadeev @lumtis @salmad3 @julienrbrt