From 290fc63869d3430190a4ffc4477c43e69a596c3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jer=C3=B3nimo=20Albi?= <jeronimo.albi@tendermint.com>
Date: Wed, 18 Oct 2023 12:36:11 +0200
Subject: [PATCH] ci: fix integration tests and lint workflows (#3700)

* ci: fix integration tests and lint workflows

* fix: lint issues
---
 .github/workflows/test-integration.yml | 17 ++++++-----------
 .github/workflows/test-lint.yml        |  3 +++
 ignite/pkg/cache/cache.go              |  2 +-
 ignite/pkg/cosmosanalysis/app/app.go   | 10 +++++-----
 ignite/pkg/placeholder/error.go        |  5 +++--
 5 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/test-integration.yml b/.github/workflows/test-integration.yml
index c67925cc50..7092742213 100644
--- a/.github/workflows/test-integration.yml
+++ b/.github/workflows/test-integration.yml
@@ -42,22 +42,17 @@ jobs:
             go.sum
             **/testdata/**
 
-      - uses: actions/cache@v3
-        if: env.GIT_DIFF
-        with:
-          path: |
-            ~/.cache/go-build
-            ~/go/pkg/mod
-          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
       - uses: actions/setup-go@v4
         if: env.GIT_DIFF
         with:
-          go-version: '1.21'
+          go-version: 'stable'
+
       - name: Run Integration Tests
         if: env.GIT_DIFF
-        run: GOSUMDB=off go test -v -timeout 120m ./integration/${{ matrix.test-path }}
+        env:
+          GOTOOLCHAIN: local+path
+          GOSUMDB: off
+        run: go test -v -timeout 120m ./integration/${{ matrix.test-path }}
 
   status:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/test-lint.yml b/.github/workflows/test-lint.yml
index 46cc7973c2..58c3d30fbb 100644
--- a/.github/workflows/test-lint.yml
+++ b/.github/workflows/test-lint.yml
@@ -24,10 +24,13 @@ jobs:
             **/*.go
             go.mod
             go.sum
+
       - uses: actions/setup-go@v4
         if: env.GIT_DIFF
         with:
           go-version-file: go.mod
+          cache: false
+
       - uses: golangci/golangci-lint-action@v3
         if: env.GIT_DIFF
         with:
diff --git a/ignite/pkg/cache/cache.go b/ignite/pkg/cache/cache.go
index 061818ed5c..ad115d7888 100644
--- a/ignite/pkg/cache/cache.go
+++ b/ignite/pkg/cache/cache.go
@@ -94,7 +94,7 @@ func (c Cache[T]) Put(key string, value T) error {
 func (c Cache[T]) Get(key string) (val T, err error) {
 	db, err := openDB(c.storage.storagePath)
 	if err != nil {
-		return
+		return val, err
 	}
 	defer db.Close()
 
diff --git a/ignite/pkg/cosmosanalysis/app/app.go b/ignite/pkg/cosmosanalysis/app/app.go
index b240fe86da..77b956aeea 100644
--- a/ignite/pkg/cosmosanalysis/app/app.go
+++ b/ignite/pkg/cosmosanalysis/app/app.go
@@ -220,25 +220,25 @@ func newUnexpectedTypeErr(n any) error {
 func findBasicManagerRegistrations(n ast.Node, pkgDir string, fileImports map[string]string) (packages []string, err error) {
 	callExprType, ok := n.(*ast.CallExpr)
 	if !ok {
-		return
+		return packages, err
 	}
 
 	selectorExprType, ok := callExprType.Fun.(*ast.SelectorExpr)
 	if !ok {
-		return
+		return packages, err
 	}
 
 	identExprType, ok := selectorExprType.X.(*ast.Ident)
 	if !ok {
-		return
+		return packages, err
 	}
 	basicModulePkgName := findBasicManagerPkgName(fileImports)
 	if basicModulePkgName == "" {
 		// cosmos-sdk/types/module is not imported in this file, skip
-		return
+		return packages, err
 	}
 	if identExprType.Name != basicModulePkgName || selectorExprType.Sel.Name != "NewBasicManager" {
-		return
+		return packages, err
 	}
 
 	// Node "n" defines the call to NewBasicManager, let's loop on its args to discover modules
diff --git a/ignite/pkg/placeholder/error.go b/ignite/pkg/placeholder/error.go
index a649d95a12..a2fe398a42 100644
--- a/ignite/pkg/placeholder/error.go
+++ b/ignite/pkg/placeholder/error.go
@@ -1,6 +1,7 @@
 package placeholder
 
 import (
+	"errors"
 	"fmt"
 	"strings"
 
@@ -18,8 +19,8 @@ type MissingPlaceholdersError struct {
 
 // Is true if both errors have the same list of missing placeholders.
 func (e *MissingPlaceholdersError) Is(err error) bool {
-	other, ok := err.(*MissingPlaceholdersError) //nolint:errorlint
-	if !ok {
+	var other *MissingPlaceholdersError
+	if !errors.As(err, &other) {
 		return false
 	}
 	if len(other.missing) != len(e.missing) {