Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support JSX file extension #603

Merged
merged 1 commit into from
Dec 30, 2019
Merged

feat: Support JSX file extension #603

merged 1 commit into from
Dec 30, 2019

Conversation

RakeshUP
Copy link
Member

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature to support .jsx file extensions

  • What is the current behavior? (You can also link to an open issue here)
    When a react component that uses JSX syntax is named .jsx, the component resolver throws "InvalidComponentError"

  • What is the new behavior (if this is a feature change)?
    Component Resolver has been updated to handle .jsx files

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Closes: Support JSX file extension #491

@RakeshUP RakeshUP requested a review from mathisonian December 30, 2019 12:44
@mathisonian
Copy link
Member

Perfect, thanks @RakeshUP! ✨

@mathisonian mathisonian merged commit d455bd3 into idyll-lang:master Dec 30, 2019
Copy link
Member

@mathisonian mathisonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JSX file extension
2 participants