Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: comment adds a line between previous and later components #578

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

rollaball
Copy link
Member

@rollaball rollaball commented Aug 3, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds a break when a new line comment is used.

  • What is the current behavior? (You can also link to an open issue here)

Hello
// comment
World

turns to
Screenshot from 2019-08-03 16-53-46

  • What is the new behavior (if this is a feature change)?
Hello
// comment
World

turns to

Screenshot from 2019-08-03 16-47-22

@rollaball rollaball marked this pull request as ready for review August 3, 2019 11:37
@mathisonian mathisonian merged commit a3b4cf6 into idyll-lang:master Aug 3, 2019
@mathisonian
Copy link
Member

Nice work! I'm sending you an invite to the Idyll organization since you've made substantial contributions. That will let you branch directly off of master for future PRs, which makes it a bit easier to work on them collaboratively.

@rollaball
Copy link
Member Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants