Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused text feature. fixes #503 #518

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

mathisonian
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fixes a bug where the text property was incorrectly being used to set the children of components.

  • What is the current behavior? (You can also link to an open issue here)
    See Passing a text prop to a component unexpectedly adds the prop value as a child #503

  • What is the new behavior (if this is a feature change)?
    The text property is treated as a standard property.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@mathisonian mathisonian merged commit 2c7a4f5 into master May 29, 2019
@mathisonian mathisonian deleted the text-prop-insert branch March 25, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant