Fix for anonymous class definition and update to Idris 0.9.20 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Closure.run() function was called which has a return type of void, thus not allowing any return value to get through.
… and added support for Java Boolean <-> Idris Bool conversions.
…ed name mangling.
… method size limit. Now let's hope we don't hit the method count limit (a simple fix would be to move all the APPLY and EVAL case fn's to inner classes - which maybe I should just go ahead and do while it's fresh).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of anonymous class definition wraps the function call in a call to
Closure.run()which has a return type ofvoidthus not allowing any return value from Idris to get returned by the Java method.