-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midi clock stop event does not stop a timeline. #22
Comments
I did some additional tinkering and I set up my DAW to output MIDI song position pointer. Now what i see is: The timeline responds to the DAW's start messages and tempo settings but when the stop message is received, the timeline keeps going and keeps outputing notes, also the message "Timeline: Stopping" is displayed. |
Here's a PR that fixes this issue for me. |
Hey @rvega! Nice to see you here. Sorry for the slow reply, just working through a bit of a PR backlog... What DAW are you using? I tested the current behaviour with Ableton Live and it works OK. But I've just been doing some reading and it sounds like some devices/DAWs continue to send MIDI clock events even when the transport is stopped, which I suspect may be what you're seeing here. |
Hi Daniel! @ideoforms |
Thanks @rvega, that's great, I'll do some tests in Bitwig. This PR looks good though so I anticipate merging. Cheers and happy new year! |
I have something very simple like:
And I'm sending midi clock and start/stop events from a DAW.
What I'm trying to achieve is for the timeline/sequence to start/stop when the DAW sends the start/stop events and for it to be synced with the DAW's MIDI clock.
The text was updated successfully, but these errors were encountered: