Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable two way syncing for DriveSync #372

Open
andybak opened this issue Jan 24, 2023 · 2 comments
Open

Enable two way syncing for DriveSync #372

andybak opened this issue Jan 24, 2023 · 2 comments
Labels
feature request Request to alter functionality

Comments

@andybak
Copy link
Contributor

andybak commented Jan 24, 2023

Example code from DriveSync.cs:

folderSyncs.Add(AddSyncedFolderAsync(
    "Videos",
    App.VideosPath(),
    deviceRootId,
    SyncType.Upload,
    SyncedFolderType.Videos,
    token,
    excludeExtensions: new[] { ".bat", ".usda" }));

All that's needed is to change SyncType to UploadAndDownload

I tested and it works. But:

  1. We should probably not change this without adding a UI toggle and defaulting to "off"
  2. How do we trigger a sync? Polling? A manual button to click? (See calls to SyncLocalFilesAsync for how it's currently triggered)
  3. As an extra bit of security - change from excludeExtensions to includeExtensions?
@mikeskydev mikeskydev added the feature request Request to alter functionality label Jan 25, 2023
@mikeskydev mikeskydev added this to the Post 2.0 milestone Jan 25, 2023
@mikeskydev mikeskydev moved this to Feature Request in Open Brush Roadmap Feb 5, 2023
@andybak
Copy link
Contributor Author

andybak commented Feb 15, 2023

For the record I've enabled this in the Plugin Scripting branch as it's the only way to easily edit scripts on a PC and get them on to a Quest.

@TimAidley
Copy link
Contributor

IIRC the reason we only did the syncing one way in Tilt Brush was that we were worried about edge cases to with how to handle sketches being altered in more than one place etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request to alter functionality
Projects
Status: Feature Request
Development

No branches or pull requests

3 participants