Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged the (old) shared library support into the new structure #678

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

fver
Copy link
Contributor

@fver fver commented Aug 28, 2023

Merged the shared library support to the latest branch. All credit to the original creator @pneff of this PR.
Since file locations changed, this was not automatic but it works for me, syncing a +200k photo library, no other extensive testing done.

@AndreyNikiforov
Copy link
Collaborator

I am glad it worked for your ad-hoc testing. To merge this PR into main code base, we need all current tests working and new ones created for new functionality.

@fver
Copy link
Contributor Author

fver commented Aug 29, 2023

working on fixing the tests...

@laurensguijt
Copy link

Is there any way to already test the shared library support ? I'm currently running the latest version without shared library support on my unraid server.

@lonevvolf
Copy link

Is there any way to already test the shared library support ? I'm currently running the latest version without shared library support on my unraid server.

I suppose you could test version being merged from at https://github.com/fver/icloud_photos_downloader/tree/master

@lonevvolf
Copy link

lonevvolf commented Sep 16, 2023

working on fixing the tests...

@fver Any luck with this so far?

@fver
Copy link
Contributor Author

fver commented Sep 20, 2023

working on fixing the tests...

@fver Any luck with this so far?

Slowly, all tests fail due to incompatible manually adapted VCR recordings, one by one trying to fix them with limited time available.

@fver
Copy link
Contributor Author

fver commented Sep 25, 2023

operator mistake in last merging branch, all tests should pass now.

libraries_dict = icloud.photos.libraries
library_names = libraries_dict.keys()
print(*library_names, sep="\n")
sys.exit(0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change to return, so program exists are only at top level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapted, in a separate commit - extra return triggered a lint warning, so did some refactor

tests/vcr_cassettes/2sa_flow_valid_device.yml Outdated Show resolved Hide resolved
tests/vcr_cassettes/2sa_flow_valid_device.yml Outdated Show resolved Hide resolved
@gus-abreu
Copy link

Just stumbled upon this issue and gladly saw this PR is on it's way to master. Thanks a lot for the effort everyone. There's definitely many people who need this (and likely to increase over time). I'll do my best to test it and repot/fix any problems that I find.

@AndreyNikiforov AndreyNikiforov merged commit afd6f8a into icloud-photos-downloader:master Sep 26, 2023
16 checks passed
@AndreyNikiforov
Copy link
Collaborator

#455, #489, #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants