ROP login does not return failure info

[davydnorris]

If you look at the example code using the ROP login approach, you see that the option failureFlash is set to true; however, unlike all the other places where errors are caught, the callback doesn't return any information to the Passport's strategy.fail() method.

This means that no details of why the ROP login failed get propagated back to the flash area. I chased this one down for ages in my code only to find the problem is in the lib.

See: webapp-strategy.js, line 248