Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format 'gggg-wo' give the wrong result when set locale to zh-tw #1969

Closed
tobemaster56 opened this issue Jun 29, 2022 · 1 comment · Fixed by #1976
Closed

format 'gggg-wo' give the wrong result when set locale to zh-tw #1969

tobemaster56 opened this issue Jun 29, 2022 · 1 comment · Fixed by #1976
Labels
released

Comments

@tobemaster56
Copy link

Describe the bug
i create a codesandbox:

https://codesandbox.io/s/confident-sky-hnoxuf?file=/src/index.js

image

when i set locale to zh-cn, format 'gggg-wo', the result is ok
but, when i change locale to zh-tw, the result is not ok

i guess the reason is here，in locale/zh-cn.js
image

but in locale/zh-tw.js
image

Expected behavior
show the correct value，eg 2022-27週

Information

  • Day.js Version [e.g. v1.11.3]
@zonemeen zonemeen mentioned this issue Jul 6, 2022
Merged
@iamkun
Copy link
Owner

iamkun commented Jul 19, 2022

🎉 This issue has been resolved in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: weeks with ordinal give wrong result zonemeen/dayjs
2 participants
@tobemaster56 @iamkun