Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings for arraySupport missed #1170

Closed
Lonli-Lokli opened this issue Oct 27, 2020 · 4 comments · Fixed by #1401
Closed

Typings for arraySupport missed #1170

Lonli-Lokli opened this issue Oct 27, 2020 · 4 comments · Fixed by #1401
Labels
☢️Bug Something isn't working help wanted Extra attention is needed released

Comments

@Lonli-Lokli
Copy link

Describe the bug
arraySupport (#1129) lacks Typescript typings

Expected behavior
It should be possible to use arrays with typescript

Information

  • Day.js Version 1.9.4
  • OS: Win10
  • Browser Chrome
  • Time zone: GMT+3
@iamkun
Copy link
Owner

iamkun commented Oct 28, 2020

Thanks, will support it.

A problem here seems we can not update the dayjs function typing via another .d.ts file in plugin.

@iamkun iamkun added ☢️Bug Something isn't working help wanted Extra attention is needed labels Oct 28, 2020
@Lonli-Lokli
Copy link
Author

@iamkun why?
I believe it's pretty common, see https://www.damirscorner.com/blog/posts/20200911-ExtendingTypescriptTypeDefinitions.html as an example.

@iamkun
Copy link
Owner

iamkun commented Nov 2, 2020

I've tried but seems not working.
Would you like to draft a pull request to fix this? It is expected to update this file https://github.com/iamkun/dayjs/blob/dev/types/plugin/arraySupport.d.ts to make it work.

@JasonHK JasonHK mentioned this issue Mar 7, 2021
Merged
@iamkun
Copy link
Owner

iamkun commented May 26, 2021

🎉 This issue has been resolved in version 1.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed missing types for ArraySupport plugin JasonHK-Forks/dayjs
2 participants
@Lonli-Lokli @iamkun