Implementing arm support with #66 #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 77.15% 76.85% -0.30%
==========================================
Files 8 8
Lines 591 605 +14
Branches 137 140 +3
==========================================
+ Hits 456 465 +9
- Misses 105 108 +3
- Partials 30 32 +2
Continue to review full report at Codecov.
|
|
Thanks for your contribution 🙏 Installation testing is mostly handled indirectly, as the entire suite will fail if solc can't install. Unfortunately this only really covers linux and windows - the compile time is so slow it timed out the CI when I tried. The test suite should include some level of mocking to make sure that the compile functions are at least called properly - but it doesn't today, so I can't rightly ask you to be the one to add those tests :) a new major release is on the nearish horizon, it will definitely be handled by then. |
solcx/install.py
Outdated
| LOGGER.info("solc {} successfully installed at: {}".format(version, binary_path)) | ||
| finally: | ||
| lock.release() | ||
| if arch == "arm": |
There was a problem hiding this comment.
I think this would be more fitting as the first if statement in the sequence of if/elif starting at line 244. It's important that it happens within the context of try/finally so that the process lock is released when it completes.
Added arm check and support with reordered install_solc elifs
|
Also, install_deps currently give a warning on raspbian (Ubuntu Aarch64 however should be fine) but it still works and I also submitted a pathc to Solidity that it treats Raspbian as Debian. |
Good call! There is also a push to expand the range of pre-compiled |
ghost
mentioned this pull request
What I did
Implemented arch check and arm compile as per
Related issue: #
#66
How I did it
Described in issue above. Install_arm and install_osx both call compile_solc with osx checking the ox parameter and arm not checking anything so far.
How to verify it
Checklist
No test cases as I honestly wasn't sure what to test, and looking for examples there were very few tests related to install. Rest of checklist will follow.