localization: el #1844
Open
localization: el #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added el/messages.json
|
I will try to review it and see if some other users can give feedback as well. Thank you for you effort! |
minor corrections
some last corrections
|
The original translation effort was a bit of a mess. Now every line matches it's English counterpart making it easier to review and make future additions |
|
@konstkarapan can you test this with the latest configurator, since we now changed to Electron? |
|
I'll test it asap |
|
You may find that el needs to be added on about line 13 of js/localization.js |
mmosca
reviewed
Aug 9, 2024
mmosca
reviewed
Aug 9, 2024
mmosca
reviewed
Aug 9, 2024
mmosca
reviewed
Aug 9, 2024
| @@ -10,7 +10,7 @@ const i18nextXHRBackend = require('i18next-xhr-backend'); | |||
| const Store = require('electron-store'); | |||
| const store = new Store(); | |||
|
|
|||
| const availableLanguages = ['en']; | |||
| const availableLanguages = ['en' , 'el']; | |||
There was a problem hiding this comment.
We should probably auto populate this list.
Not a change you need to make, but an acknowledgement that this is not ideal.
|
@mmosca What is the expected behaviour of the language selector at the application settings? Changing languages on it seems to do nothing |
revert some terms back to English and correct some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greek🇬🇷 language for the inav configurator