Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Windows wrapper script #2120

Merged
merged 2 commits into from
Jul 13, 2019
Merged

Enhanced Windows wrapper script #2120

merged 2 commits into from
Jul 13, 2019

Conversation

Varstahl
Copy link
Contributor

@Varstahl Varstahl commented Jul 3, 2019

I added a bit of functionality to the apktool wrapper script and thought I'd share. This has several advantages compared to the base currently available:

  1. No environment pollution
  2. Automatic pick of the latest version, without the need to rename
  3. Supports command-less calls, if the only parameter is a directory or an apk
    • Supports drag & drop
    • Supports double-click
    • Supports "Send to" functionality
  4. Pauses when ran non interactively, so the prompt doesn't automatically close

If the script finds an apktool.jar it's selected automatically, otherwise it looks for jar versions available in its directory with the name format apktool_<version>.jar and picks the latest accordingly.

With drag & drop, send-tos and calls:

  • if the parameter is an apk file, the script issues the d command
  • if the parameter is a directory, the script issues the b command

@iBotPeaches
Copy link
Owner

Thanks for the PR! Going to give this a spin on windows and do a little-QA and then merge it.

@iBotPeaches
Copy link
Owner

Worked out great in testing. Rebased and waiting on tests and will get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants