-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource entry already has bag item (double entity) #1927
Comments
To be honest @datdevs... The Advanced Apktool software hasn't been updated by @BDFreak since 10 Feb 2016 as reflected on the following link. https://forum.xda-developers.com/showthread.php?t=2639400 I do believe that @BDFreak is a very good developer but, I just wish that he would update the Advanced Apktool software since, at the time, it was an extremely valuable tool out there. I'm just providing my thoughts and pointing something out that you may not be aware of. Good Luck! :-) ~Ibuprophen |
any body know about this problem |
i also faced this problem |
just delete doubles.. |
if we delete phone rebooting and stuck at bootloop |
you test and try it |
Do you have an apk for this? I'm curious if the duplicated resources exist in the original or if apktool decoded them improperly. |
yes i have an apk i can upload you try on this unpack and repack |
C:\Users\Piya Jee\Desktop\apktool2 work on oreo>apktool b framework-res |
this is stock framework-res.apk try and please tell me solution for this |
Closing as duplicate - #315 |
@iBotPeaches Are you sure this is a duplicate of #315? 🤔 That issue is talking about extraneous double quotes inside of otherwise successfully re-encoded APKs, whereas this one is talking about an error causing the re-encoding to fail for reasons that have nothing to do with quotes or even strings for that matter. The base APK inside of the TikTok XAPK for example causes the following error while re-encoding:
The "resource entry" mentioned in the error message looks like this: <style name="iz" parent="@style/fc">
<item name="android:windowBackground">@drawable/o5</item>
<item name="android:windowContentTransitions">true</item>
<item name="android:windowContentTransitions">true</item> <!-- Duplicate item -->
<item name="android:windowSharedElementEnterTransition">@transition/a</item>
<item name="android:windowSharedElementExitTransition">@transition/a</item>
<item name="android:windowSharedElementReturnTransition">@transition/a</item>
<item name="android:windowSharedElementReenterTransition">@transition/a</item>
</style> I suggest reopening this issue and renaming it to |
Thanks - I see what you mean. Reopened. |
Investigated this as a by-product of triaging a different ticket - #3098 (comment) So I started a patch and it failed miserably.
So while it worked for the issue apk, it failed in these regards.
So I fear I still have no true root understanding of why the duplicate bag items exist. It must act like a fallback mechanism so systems can leverage different types of values depending on the OS version. However, take Instagram which has duplicate <style name="InThreadComposerTextArea">
<item name="android:textColor">?textColorPrimary</item>
<item name="android:textColorHint">?textColorTertiary</item>
<item name="android:textColorHint">@color/igds_secondary_text</item>
...
</style> If the first issue was in 2018 and aapt2 came out in 2017 - I am starting to think this research is useless. Its clear that aapt2 doesn't care about this, so maybe we patch out the restriction in aapt1 and see how that handles as a test. Once I get my aapt/aapt2 repos up to date - I'll work on that. |
Hacky workaround to aapt binary - iBotPeaches/platform_frameworks_base@bc4ca27 If this works with my only test of Instagram, going to go forward with it and close this. |
Did your hacky workaround to the aapt binary work on Instagram? It seems like the patch is in-place then for future versions of apktool? |
Yes to the extent that it compiled w/ no issue. Running on device I did not test. |
… I found Original: iBotPeaches/Apktool#3098 End of Discussion: iBotPeaches/Apktool#1927
Information
apktool -version
) - 2.3.4Stacktrace/Logcat
W: E:\ANDROID-G\AndroidDEV\AdvancedApkTool\3-Out\framework-res.apk\res\values\styles.xml:2452: error: Resource entry Theme.DeviceDefault already has bag item dropdownListPreferredItemHeight.
W: E:\ANDROID-G\AndroidDEV\AdvancedApkTool\3-Out\framework-res.apk\res\values\styles.xml:2451: Originally defined here.
The text was updated successfully, but these errors were encountered: