From 81c518a213709675a3f00d268e641a4f4785d396 Mon Sep 17 00:00:00 2001
From: Marcos Prieto <marcospri@gmail.com>
Date: Fri, 2 Dec 2022 12:18:24 +0100
Subject: [PATCH] Move notes textarea to the top

---
 lms/templates/admin/instance.html.jinja2 | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lms/templates/admin/instance.html.jinja2 b/lms/templates/admin/instance.html.jinja2
index 5863fbc34f..852ff92e0e 100644
--- a/lms/templates/admin/instance.html.jinja2
+++ b/lms/templates/admin/instance.html.jinja2
@@ -32,7 +32,8 @@
 
 {% macro settings_textarea(label, setting, sub_setting, field_name, default='') %}
     {% call macros.field_body(label) %}
-        <textarea class="textarea" name="{{ setting }}.{{ sub_setting }}">{{ instance.settings.get(setting, sub_setting, default) or '' }}</textarea>
+        {% set text = instance.settings.get(setting, sub_setting, default) or ''  %}
+        <textarea class="textarea" name="{{ setting }}.{{ sub_setting }}">{{ text }}</textarea>
     {% endcall %}
 {% endmacro %}
 
@@ -51,6 +52,14 @@
 <form method="POST" action="{{ request.route_url("admin.instance.id", id_=instance.id) }}">
     <input type="hidden" name="csrf_token" value="{{ get_csrf_token() }}">
 
+    <fieldset class="box">
+        {{ settings_textarea("Notes", "hypothesis", "notes") }}
+        {{ macros.disabled_text_field("Consumer key", instance.consumer_key) }}
+        {{ macros.form_text_field(request, "Deployment ID", "deployment_id", field_value=instance.deployment_id) }}
+        {{ macros.form_text_field(request, "LMS URL", "lms_url", field_value=instance.lms_url) }}
+    </fieldset>
+
+
     <fieldset class="box mt-6">
         <legend class="label has-text-centered">Organization</legend>
         {{ macros.organization_preview(request, instance.organization) }}
@@ -61,12 +70,6 @@
         {{ macros.registration_preview(request, instance.lti_registration) }}
     </fieldset>
 
-    <fieldset class="box">
-        {{ macros.disabled_text_field("Consumer key", instance.consumer_key) }}
-        {{ macros.form_text_field(request, "Deployment ID", "deployment_id", field_value=instance.deployment_id) }}
-        {{ macros.form_text_field(request, "LMS URL", "lms_url", field_value=instance.lms_url) }}
-    </fieldset>
-
     <fieldset class="box">
         <legend class="label has-text-centered">Tool Consumer</legend>
         {{ macros.disabled_text_field("GUID", instance.tool_consumer_instance_guid) }}
@@ -141,7 +144,6 @@
         {{ settings_text_field("JSTOR site code", "jstor", "site_code") }}
     </fieldset>
 
-    {{ settings_textarea("Notes", "hypothesis", "notes") }}
     {{ macros.created_updated_fields(instance) }}
 
     <div class="has-text-right mb-6">